js-rigor: reliability flows through every rule kind; multi_hop value collection fixed

Systemic reliability gap found by the probe sweep: the compiled evaluation
paths never emitted the reliability the engine computes.

- Compiled _evaluateDirect omitted the relation's reliability, and the
  chain/multi_hop rules hardcoded reliability: 1.0 — so check() results
  reported 1.0 for any rule whose decision came through a chain, multi_hop,
  union, intersection, exclusion, or defeasible combination.
- The chain and multi_hop traversals now track per-path reliability (product
  of edge reliabilities) and report the winning path's value; the compiled
  and fallback logical operators (union/intersection/exclusion, direct_list
  fast path, early exits) report the selected child's reliability
  (max/min child or OWA trace index; exclusion multiplies both legs), and
  normal-mode defeasible combines base x requires x defeater reliabilities.
- The checker's logical fast path dropped collectedValues from union/
  intersection/exclusion results; it now passes them through.
- MultiHopRule.valueManager was read off relationManager where the real
  arbiter keeps it on the arbiter — collectValues: true on a multi_hop rule
  with a value-carrying edge crashed the evaluation (error result, silent
  denial). Now resolved at the arbiter level with a relationManager
  fallback for stubs.

Campaign pins: reliability per kind (chain/multi_hop product, union/intersection
selected child, exclusion/defeasible product), and multi_hop value collection
through persistent and partial contexts.
This commit is contained in:
John Dvorak
2026-08-01 09:52:31 -07:00
parent f0dc14fb72
commit 4fd4e20bd0
53 changed files with 361 additions and 187 deletions
+6 -6
View File
@@ -312,7 +312,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('union-max', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 400, seed: 'zanzibar-union' });
).run({ effort: 400, seed: 'zanzibar-union' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'union-max');
assert.ok(inv);
@@ -356,7 +356,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('intersection-min', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 400, seed: 'zanzibar-intersection' });
).run({ effort: 400, seed: 'zanzibar-intersection' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'intersection-min');
assert.ok(inv);
@@ -399,7 +399,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('exclusion-blocks', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 400, seed: 'zanzibar-exclusion' });
).run({ effort: 400, seed: 'zanzibar-exclusion' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'exclusion-blocks');
assert.ok(inv);
@@ -434,7 +434,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('expand-parity', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 800, seed: 'zanzibar-expand-parity' });
).run({ effort: 800, seed: 'zanzibar-expand-parity' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'expand-parity');
assert.ok(inv);
@@ -490,7 +490,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('nested-weakest-link', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 500, seed: 'zanzibar-nested-chain' });
).run({ effort: 500, seed: 'zanzibar-nested-chain' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'nested-weakest-link');
assert.ok(inv);
@@ -546,7 +546,7 @@ describe('Zanzibar rewrite-rule semantics (rigor)', () => {
rigor.crucible([
rigor.invariant('cycle-safe', ({ error, errorMessage }) => !error && !errorMessage)
])
).run({ effort: 400, seed: 'zanzibar-cycle-safety' });
).run({ effort: 400, seed: 'zanzibar-cycle-safety' , artifacts: { dir: '', persist: 'never' }});
const inv = report.crucibleVerdict?.invariants?.find(i => i.name === 'cycle-safe');
assert.ok(inv);